Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-small components to be used inside a condensed table #2806

Closed
tomshen opened this issue Aug 15, 2018 · 2 comments
Closed

Allow non-small components to be used inside a condensed table #2806

tomshen opened this issue Aug 15, 2018 · 2 comments

Comments

@tomshen
Copy link
Contributor

tomshen commented Aug 15, 2018

Environment

  • Package version(s): 3.0.1
  • Browser and OS versions: Google Chrome 68.0.3440.106, MacOS 10.13.6

Steps to reproduce

<HTMLTable small={true}>
  .
  .
  .
  <Button small={false}>Cancel</Button>
  .
  .
  .
</HTMLTable>

Actual behavior

A small button renders in a condensed table.

Expected behavior

A normally sized button renders in a condensed table.

Possible solutions

@tomshen tomshen changed the title Allow non-small components to be nested under small components Allow non-small components to be used inside a condensed table Aug 15, 2018
@giladgray
Copy link
Contributor

Remove .#{$ns}-small &

this exists for <ButtonGroup small> so we cannot remove it. we could change the selector to include a > but then we'd also need to handle the wrapped-in-a-Popover case

@giladgray
Copy link
Contributor

I'd be okay with bringing back condensed though it's gotta be done in a non-breaking way.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants