Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint Select Search: If you hit enter with no selections, select the first result #2867

Closed
switz opened this issue Aug 23, 2018 · 0 comments

Comments

@switz
Copy link
Contributor

switz commented Aug 23, 2018

Environment

  • Package version(s): Select 3.1.0
  • Browser and OS versions: Chrome 68.0.3440.106 (Mac OS 10.12.6)

Feature request Bug Report

If you are searching for something and your previous selection is filtered out, you are left with no selections. If you then hit enter, the select popup closes with a noop.

I propose if you hit enter while searching and have no selection, the first result is chosen. It especially feels odd to hit enter when only one item from your search remains and nothing happens.

Edit: This actually appears to be a regression since the Select version 3.0.0-beta.0 works as suggested but Select version 3.1.0 does not work:

3.0.0-beta.0: https://codesandbox.io/s/912pomvr6o
3.1.0: https://codesandbox.io/s/4lq6o71rnx

Proposed Examples

open select
search for "apple"
1 result, no selection
enter
apple is selected

open select
search for "pea"
2 results (peach && pear), no selection
enter
peach is selected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant