Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateInput popover closes when clicking to month of min/max date when no date is selected #3308

Closed
cnrudd opened this issue Jan 22, 2019 · 4 comments

Comments

@cnrudd
Copy link

cnrudd commented Jan 22, 2019

Environment

  • Package version(s): DateTime 3.6.0
  • Browser and OS versions: Mac OS 10.14.2 Chrome 71.0.3578.98

Steps to reproduce

  1. Go to https://blueprintjs.com/docs/#datetime/dateinput
  2. Click into the date input field.
  3. Delete the date value from the input field, so that the field has no value.
  4. In the popover, navigate forward or backward to the month that contains the max or min date using the <> arrow buttons. You will see that the popover closes prematurely when it reaches those 'end of range' months.

Actual behavior

If no date is selected, the popover closes prematurely when a user clicks on the <> buttons to reach the months that contains the max or min dates. This prevents a user from selecting a date in those months. (Well, a user could select a date in those months if he first selects a date that is not in those months, and then clicks into those 'end of range' months, but a user shouldn't have to do that.)

Expected behavior

When no date is selected, the popover should stay open when those 'end of range' months are reached by clicking on the <> buttons. This would allow a date in those months to be selected.

Possible solution

If you agree that this is a bug, I'll look into a solution if you haven't found one yet.

@adidahiya
Copy link
Contributor

No longer reproducible, I believe this was fixed recently by #4316

@j-perl
Copy link

j-perl commented Jan 4, 2021

The problem still occurs for me.

Package version: DateTime 3.20.0
Browser and OS versions: Mac OS 11.1 Chrome 87.0.4280.88

@cnrudd
Copy link
Author

cnrudd commented Jan 4, 2021

@ j-perl. Strange. I cannot reproduce the bug on this page:
https://blueprintjs.com/docs/#datetime/dateinput

I have the same specs as you:
Package version: DateTime 3.20.0
Browser and OS versions: Mac OS 11.1 Chrome 87.0.4280.88

@j-perl
Copy link

j-perl commented Jan 4, 2021

My bad, I had to reload the web app after running yarn. It's working now. Thanks for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants