Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons inside Menu component does not have intent applied #3593

Closed
jacekjagiello opened this issue Jun 12, 2019 · 1 comment
Closed

Icons inside Menu component does not have intent applied #3593

jacekjagiello opened this issue Jun 12, 2019 · 1 comment
Labels
Package: core Resolution: by design

Comments

@jacekjagiello
Copy link
Contributor

Environment

  • Package version(s): 3.15.1
  • Browser and OS versions: probably all

Actual behavior

Similar to #3042, but affecting Menu component, Icons passed to MenuItem components does not have intent color applied

Expected behavior

Intent colors should be applied

Possible solution

Similar ro #3355 , I'll do PR soon.

Does anyone have other components in mind, that may have a similar issue?
@jacekjagiello jacekjagiello changed the title [Core] Icons inside Menu component does not have intent applied Icons inside Menu component does not have intent applied Jun 12, 2019
@jacekjagiello jacekjagiello mentioned this issue Jun 13, 2019
Closed
2 tasks
@adidahiya
Copy link
Contributor

MenuItem supports intent, and I'm not convinced that the icon needs its own special color unique from the containing item. Closing as "by design", similar to #3597 (comment)

@adidahiya adidahiya mentioned this issue Jun 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: core Resolution: by design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core] Fixed not applying intent color for icon inside menu component jacekjagiello/blueprint-fork
2 participants
@adidahiya @jacekjagiello