Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spinner colors consistent #369

Closed
pkwi opened this issue Dec 14, 2016 · 5 comments
Closed

Make spinner colors consistent #369

pkwi opened this issue Dec 14, 2016 · 5 comments

Comments

@pkwi
Copy link
Contributor

pkwi commented Dec 14, 2016

Bug report

  • Package version(s): 1.3.1
  • Browser and OS versions: all

Actual behavior

dark spinners use the following colors:

Track: gray1 (20%)
Head: gray1 (100%)

screen shot 2016-12-14 at 5 06 18 pm

Expected behavior

Track: black (30%)
Head: gray1 (100%)

screen shot 2016-12-14 at 5 02 45 pm

@llorca llorca added this to the 1.5.0 milestone Dec 14, 2016
@llorca llorca changed the title Change dark spinner colors Make spinner colors consistent Dec 14, 2016
@leebyp
Copy link
Contributor

leebyp commented Jan 5, 2017

@pkwi the contrast with the proposed colors are coming out different to your screenshot, do we want to tweak some more?

screen shot 2017-01-05 at 11 50 58

@leebyp leebyp self-assigned this Jan 5, 2017
@pkwi
Copy link
Contributor Author

pkwi commented Jan 5, 2017

@leebyp ha! my fault. The head should be using gray3 (#8A9BA8) not gray 1.

@giladgray
Copy link
Contributor

@pkwi the contrast between the track and background in your proposal is very low, almost too low...
though in the current incarnation the contrast between track and head are too low...

@pkwi
Copy link
Contributor Author

pkwi commented Jan 5, 2017

Valid point @giladgray! We could increase the track's opacity to 50% (same colour/opacity as dark sliders)

screen shot 2017-01-05 at 10 34 06 pm

@leebyp
Copy link
Contributor

leebyp commented Jan 5, 2017

like the 50% a lot more (though from looking at the docs page, maybe we can go even higher)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants