Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table cell copy in IE 11 #3758

Closed
chuyachia opened this issue Sep 30, 2019 · 2 comments · Fixed by #3764
Closed

Table cell copy in IE 11 #3758

chuyachia opened this issue Sep 30, 2019 · 2 comments · Fixed by #3764
Labels
Browser: IE (deprecated) deprecated as of Blueprint v5.0 (May 2023) help wanted P2 Type: bug

Comments

@chuyachia
Copy link
Contributor

Environment

  • Package version(s): blueprintjs/table v.3.7.0
  • Browser and OS versions: IE 11 Win7

If possible, link to a minimal repro (fork this code sandbox): https://blueprintjs.com/docs/#table/features.sorting

Steps to reproduce

Follow the table documentation page instruction to select cell and copy in IE11

Actual behavior

No data was copied. Got an Unexpected call to method or property access. error.
Screenshot from 2019-09-30 14-24-22

Expected behavior

IE 11 is among the browsers that Blueprint supports. The data should be copied.

Possible solution

It seems that DataTransfer.setData only accepts "text" format in IE11 but "text/html" and "text/plain" are used in https://github.com/palantir/blueprint/blob/develop/packages/table/src/common/clipboard.ts#L107 One solution might be just using "text" as format?

@adidahiya adidahiya added Browser: IE (deprecated) deprecated as of Blueprint v5.0 (May 2023) help wanted P2 Type: bug labels Sep 30, 2019
@chuyachia
Copy link
Contributor Author

@adidahiya Do you think using just "text" instead of "text/html" and "text/plain" can be a solution?

@adidahiya
Copy link
Contributor

@chuyachia you're welcome to test it out -- just make sure the behavior for other browsers continues to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser: IE (deprecated) deprecated as of Blueprint v5.0 (May 2023) help wanted P2 Type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants