Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Menu.Item and Menu.Divider static aliases #3829

Closed
adidahiya opened this issue Nov 10, 2019 · 2 comments
Closed

Remove Menu.Item and Menu.Divider static aliases #3829

adidahiya opened this issue Nov 10, 2019 · 2 comments
Labels
Domain: API Package: core Type: breaking change Type: task
Milestone
4.0.0-alpha.0

Comments

@adidahiya
Copy link
Contributor

They cause problems like #3753 and provide no real benefit. We should just remove them in Blueprint 4.
@adidahiya adidahiya added this to the 4.x milestone Nov 10, 2019
@adidahiya adidahiya mentioned this issue Jan 19, 2021
Closed
@adidahiya
Copy link
Contributor Author

adidahiya commented Jan 19, 2021 •
edited
Loading

For posterity: the real problem was the import cycle between Menu <-> MenuItem. This causes Menu.Item to be undefined in a webpack bundle.

@adidahiya adidahiya modified the milestones: 4.x, 4.0.0-beta.0 Mar 4, 2021
@adidahiya adidahiya mentioned this issue Mar 12, 2021
Merged
@adidahiya
Copy link
Contributor Author

fixed by #4583, released in 4.0.0-alpha.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: API Package: core Type: breaking change Type: task
Projects
None yet
Milestone
4.0.0-alpha.0
Development

No branches or pull requests
1 participant
@adidahiya