Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioGroup's label prop as a ReactNode will wrap its own Label element #4459

Closed
cyu06 opened this issue Dec 16, 2020 · 1 comment
Closed

Comments

@cyu06
Copy link
Contributor

cyu06 commented Dec 16, 2020

After #4276 allowed label to be a ReactNode, I would've expected that I could pass in my own Label element rather than getting forced to get a wrapped one

{label == null ? null : <label className={Classes.LABEL}>{label}</label>}

@adidahiya
Copy link
Contributor

Well I guess that would've been a slight runtime break if we removed the wrapping label, since #4276 was just a type change. Can you describe your use case a bit more? Why do you need to customize the label?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants