Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker ignoring getFirstDayOfWeek in localeUtils (other functions there work as expected) #465

Closed
kraf opened this issue Jan 12, 2017 · 0 comments

Comments

@kraf
Copy link

kraf commented Jan 12, 2017

Bug report

I want to change the first day of the week to Monday via the localeUtils function and it's getting ignored. I tracked this down to a problem in version 2.5.0 in react-day-picker. This seems to be fixed in the new version, I even found a test for this in 3.1.0 which is missing in 2.5.0.

  • Package version(s): datetime/1.4.1

Steps to reproduce

  1. Create a DatePicker component with a localeUtils object having
getFirstDayOfWeek: () => 1

Actual behavior

First day of week is still Sunday, no matter the return of the function.

Expected behavior

First day of week should be Monday.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants