You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You get two dialogs open, one of them is empty (the one triggered by the old @HotkeysTarget API, used in <Table>).
You can even repro this in the documentation "Table features" page
Expected behavior
The two hotkeys APIs should not interfere
Possible solution
Converting Table to HotkeysTarget2 seems to work (despite some duplicate keys displayed), but we can’t introduce a breaking change to Table right now (requiring HotkeysProvider in place)... so we can either
create a new Table2 component which uses HotkeysTarget2, or
edit HotkeysEvents to not display the dialog if there are no hotkeys to show (this is a bit of a band-aid)
Since we’re going to need to migrate people to a new version of Table which uses new hotkeys anyway, we should probably make Table2...
The text was updated successfully, but these errors were encountered:
Environment
Steps to reproduce
Actual behavior
You get two dialogs open, one of them is empty (the one triggered by the old
@HotkeysTarget
API, used in<Table>
).You can even repro this in the documentation "Table features" page
Expected behavior
The two hotkeys APIs should not interfere
Possible solution
Converting Table to HotkeysTarget2 seems to work (despite some duplicate keys displayed), but we can’t introduce a breaking change to Table right now (requiring HotkeysProvider in place)... so we can either
Since we’re going to need to migrate people to a new version of Table which uses new hotkeys anyway, we should probably make Table2...
The text was updated successfully, but these errors were encountered: