Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old colors and shadows support #5077

Closed
cstffx opened this issue Dec 20, 2021 · 2 comments
Closed

Old colors and shadows support #5077

cstffx opened this issue Dec 20, 2021 · 2 comments

Comments

@cstffx
Copy link
Contributor

cstffx commented Dec 20, 2021

I have noticed some significant changes in the colors of the components (buttons, checkbox, radios and inputs) in v4. I love old colors and shadows, but I can't get stuck on old versions just for that. Could support for old colors and shadows be kept in a separate theme? Is there a way to keep the old shadows?

@cstffx cstffx changed the title Old colors support Old colors and shadows support Dec 20, 2021
@cstffx
Copy link
Contributor Author

cstffx commented Dec 20, 2021

Looking at the code I found that you guys thought about it. Excellent work.

@cstffx cstffx closed this as completed Dec 20, 2021
@adidahiya
Copy link
Contributor

Looking at the code I found that you guys thought about it.

I'm guessing you're referring to legacyColors.ts on the next branch? We do export these legacy color hex values in JS in Blueprint v4.x, but we do not support the old styles in CSS. If you upgrade to Blueprint v4.x you will get the new styles and it will be tough to revert to the old v3 styles (you'd have to compile Blueprint CSS yourself and replace a lot of Sass color variables).

We might consider adding more robust / official support for Blueprint theming in the future, but this is a large undertaking and is not currently on the roadmap (related: #248, #4029).

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants