Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog should allow attaching ref to container element #5273

Closed
adidahiya opened this issue Apr 27, 2022 · 0 comments · Fixed by #5314
Closed

Dialog should allow attaching ref to container element #5273

adidahiya opened this issue Apr 27, 2022 · 0 comments · Fixed by #5314
Labels
help wanted P2 Package: core Type: feature request

Comments

@adidahiya
Copy link
Contributor

Environment

  • Package version(s): core v4.2.1

Feature request

Currently there's no easy way to get a ref to the DOM element which is inside a Dialog's Overlay, or the .bp4-overlay element itself. This attempt in a code sandbox doesn't work: https://codesandbox.io/s/blueprint-sandbox-forked-7fy0f9?file=/src/CoreExample.tsx

We should forward <Dialog ref={...}> somehow, or add a prop to OverlayableProps like overlayRef?: React.Ref<HTMLElement | null>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted P2 Package: core Type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] feat(Dialog): add containerRef prop dlichen/blueprint
1 participant
@adidahiya