Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source map paths contain references to /home/circleci #5416

Closed
zachkirsch opened this issue Jul 6, 2022 · 1 comment · Fixed by #5415
Closed

Source map paths contain references to /home/circleci #5416

zachkirsch opened this issue Jul 6, 2022 · 1 comment · Fixed by #5415

Comments

@zachkirsch
Copy link
Contributor

Environment

  • Package version(s):
    "@blueprintjs/core": "^4.5.1",
    "@blueprintjs/icons": "^4.3.0",
    "@blueprintjs/popover2": "^1.4.1",
    "@blueprintjs/select": "^4.4.1",
  • Operating System: OSX 12.3.1
  • Browser name and version: n/a

Steps to reproduce

Run yarn start in a newly created create-react-app project

Actual behavior

You'll see errors like

Failed to parse source map from '/home/circleci/project/packages/icons/src/generated/20px/blueprint-icons-20.css' file: Error: ENOENT: no such file or directory, open '/home/circleci/project/packages/icons/src/generated/20px/blueprint-icons-20.css'

Notice the path contains /home/circleci.

Expected behavior

Source map paths should be relative.

Possible solution

Blueprint is using renderSync to generate source maps.

const result = sass.renderSync({

This generates absolute paths to source maps, and is not configurable, per sass/dart-sass#1437.

PR incoming!

@zachkirsch
Copy link
Contributor Author

Upgraded to versions listed here and confirmed fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant