Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multistep Dialog] Allow showing close buttons both in the header and footer for customizability #5758

Closed
tinopetros opened this issue Nov 18, 2022 · 0 comments · Fixed by #5762

Comments

@tinopetros
Copy link
Contributor

Feature request

It would be useful if this showCloseButtonInFooter prop being true did not mean that the close button in the dialog title will not be shown. Instead of being exclusive, both buttons can appear.

showCloseButtonInFooter: (undefined | false | true = false) Whether the footer close button is shown. The button will only appear if isCloseButtonShown is true. The close button in the dialog title will not be shown when this is true.

Usecase

Since the closeButtonInFooter has closeButtonProps it can be used to do other custom things, the most important use case for a multistep dialog button being Skip Dialog, for which developers can then have a custom callback

Examples

...
const handleSkipDialog = React.useCallback(...);
return <MultiStepDialog ... isCloseButtonShown={true} showCloseButtonInFooter{true} closeButtonProps={... onClick={handleSkipDialog}/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants