Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint V5 alpha.1 - hotkeys "space" doesn't work #6138

Closed
ptgamr opened this issue May 9, 2023 · 3 comments
Closed

Blueprint V5 alpha.1 - hotkeys "space" doesn't work #6138

ptgamr opened this issue May 9, 2023 · 3 comments

Comments

@ptgamr
Copy link

ptgamr commented May 9, 2023

Environment

  • Package version(s): 5.0.0-alpha1
  • Operating System: MacOS
  • Browser name and version: Chrome

Steps to reproduce

Looks like a hotkey with combo="space" no longer working

Actual behavior

onKeyDown does not trigger

Expected behavior

onKeyDown should be triggered

Possible solution

Looks like in comboMatches function, it's trying to compare key="space" vs key=" ", so I guess there is a bug somewhere in parsing the key

Screenshot 2023-05-09 at 11 58 49 PM Screenshot 2023-05-09 at 11 59 00 PM
@adidahiya
Copy link
Contributor

@ptgamr thanks for the bug report. I missed this special case for the space key; we should parse the "space" combo as event.key === " ". I will fix it ASAP.

@adidahiya
Copy link
Contributor

Fixed by #6139

@ptgamr
Copy link
Author

ptgamr commented May 9, 2023

@adidahiya thanks for the quick fix!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants