Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker caption select icons sometimes overlap text #6294

Closed
adidahiya opened this issue Jul 20, 2023 · 1 comment · Fixed by #6295
Closed

Datepicker caption select icons sometimes overlap text #6294

adidahiya opened this issue Jul 20, 2023 · 1 comment · Fixed by #6295

Comments

@adidahiya
Copy link
Contributor

adidahiya commented Jul 20, 2023

Environment

  • Package version(s): @blueprintjs/datetime 5.0.6, @blueprintjs/datetime2 1.0.6
  • Operating System: macOS
  • Browser name and version: Chrome 114

Steps to reproduce

Render a DatePicker, DateRangePicker, DateInput, or DateRangeInput in a way that makes the .DayPicker element take up its minimum width (currently defined as 210px)

Actual behavior

state.monthRightOffset computation inside <DatePickerCaption> is slightly off, which makes the dropdown icon overlap the month and year text by 7px

image

Expected behavior

No overlap

image

Possible solution

Maybe we just need to increase the min-width?

@adidahiya
Copy link
Contributor Author

This turned out to be a CSS specificity/ordering issue when blueprint.css was loaded onto the page after blueprint-datetime.css. It can be fixed by increasing the specificity of some datepicker caption styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant