Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogFooter children width is unconstrained #6809

Closed
berryde opened this issue May 18, 2024 · 0 comments · Fixed by #6812
Closed

DialogFooter children width is unconstrained #6809

berryde opened this issue May 18, 2024 · 0 comments · Fixed by #6812

Comments

@berryde
Copy link
Contributor

berryde commented May 18, 2024

Environment

  • Package version(s): @blueprintjs/core 5.10.3
  • Operating System: Windows
  • Browser name and version: Google Chrome 125.0.6422.60

Code Sandbox

Link to a minimal repro: https://blueprintjs.com/docs/#core/components/dialog.dialog

Steps to reproduce

  1. Inspect element on the dialog footer text in the docs example.
  2. Replace the text with a longer message, causing the footer to overflow.

Actual behavior

Providing a sufficiently large child element, such as a long text message, causes the dialog footer to overflow.

image

Expected behavior

The children should be constrained by the width of the footer, and should not overflow the footer.

image

Possible solution

Add flex-shrink: 1 to bp5-dialog-footer-main-section as in the screenshot above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant