Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use style overflow: auto in certain components in JS Table to deliver better UI when mouse is attached #720

Closed
blakegong opened this issue Feb 23, 2017 · 3 comments

Comments

@blakegong
Copy link

blakegong commented Feb 23, 2017

Currently, since TruncatedFormat and Table components are using overflow: scroll, although they display beautifully with no mouse attached:

screen shot 2017-02-23 at 6 41 48 pm

It becomes somewhat unnecessary and imperfect when you plug in the mouse. The scroll bars for X and Y are always shown in this case, even for a not overflowed component:

screen shot 2017-02-23 at 6 41 08 pm

By using overflow: auto on those components, the visual effect of those components are always displayed beautifully whether mouse is attached or not.

May I know is there any concern for using overflow: scroll? If not, I can go ahead and submit a PR for this :D

@llorca
Copy link
Contributor

llorca commented Feb 23, 2017

@themadcreator any particular reason why we used overflow: scroll here?

@blakegong
Copy link
Author

Actually this line should be changed to overflow: auto also. If you pay closer attention to the differences between the two pictures in the original post... And there might be more unnecessary overflow: scroll in this project. Should I raise another issue for that?

@llorca
Copy link
Contributor

llorca commented Mar 4, 2017

@blakegong Yes, please file an issue with the other instances that need to be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants