Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omnibar documentation should use different hotkey combo by default #2419

Closed
maclockard opened this issue Apr 23, 2018 · 2 comments · Fixed by #2722
Closed

Omnibar documentation should use different hotkey combo by default #2419

maclockard opened this issue Apr 23, 2018 · 2 comments · Fixed by #2722
Labels
Domain: documentation help wanted Type: bug

Comments

@maclockard
Copy link
Contributor

Bug report

  • Package version(s): 2.2.0
  • Browser and OS versions: Firefox 59.0.2, MacOs 10.13.4

Steps to reproduce

  1. Go to documentation page for OmniBar
  2. Hit Cmd + K

Actual behavior

Nothing Happens

Expected behavior

Omnibar opens.

Not actually a bug with blueprint, just an issue of the hotkey the documentation chose is also a default hotkey for firefox. Just need to choose a default hotkey in the documentation that doesn't conflict with hotkeys in the major browsers
@giladgray
Copy link
Contributor

seems legit. adding preventDefault prop should also solve this.

@llorca
Copy link
Contributor

llorca commented Apr 23, 2018

shift+cmd+K then?

giladgray pushed a commit that referenced this issue Jul 24, 2018
omnibar hotkey #2419
f319dcf
@giladgray giladgray mentioned this issue Jul 24, 2018
Merged
giladgray added a commit that referenced this issue Jul 25, 2018
@giladgray
[docs] handful of small edits (#2722)
3808a25 
* omnibar hotkey #2419

* navbar.heading #2695

* table.css #2696

* button alignText
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: documentation help wanted Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] handful of small edits palantir/blueprint
3 participants
@llorca @giladgray @maclockard