From 896ce41c8f1cdf8ec41efa84f9a267253b2b88e6 Mon Sep 17 00:00:00 2001
From: Bala <bala_krishna@outlook.com>
Date: Sat, 27 Apr 2019 12:52:06 +0530
Subject: [PATCH] Hover over date clears time filter fix #3420

---
 packages/datetime/src/timePicker.tsx           | 18 +-----------------
 .../datetime/test/dateRangePickerTests.tsx     | 13 +++++++++++++
 2 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/packages/datetime/src/timePicker.tsx b/packages/datetime/src/timePicker.tsx
index 0cdcbb326d..8b130d3dd9 100644
--- a/packages/datetime/src/timePicker.tsx
+++ b/packages/datetime/src/timePicker.tsx
@@ -283,23 +283,7 @@ export class TimePicker extends React.Component<ITimePickerProps, ITimePickerSta
         }
 
         if (isValid) {
-            switch (unit) {
-                case TimeUnit.HOUR_24:
-                case TimeUnit.HOUR_12:
-                    this.updateState({ hourText: text });
-                    break;
-                case TimeUnit.MINUTE:
-                    this.updateState({ minuteText: text });
-                    break;
-                case TimeUnit.SECOND:
-                    this.updateState({ secondText: text });
-                    break;
-                case TimeUnit.MS:
-                    this.updateState({ millisecondText: text });
-                    break;
-                default:
-                    throw Error("Invalid TimeUnit");
-            }
+            this.updateTime(parseInt(text, 10), unit);
         }
     };
 
diff --git a/packages/datetime/test/dateRangePickerTests.tsx b/packages/datetime/test/dateRangePickerTests.tsx
index f126d3d466..a3d54249cd 100644
--- a/packages/datetime/test/dateRangePickerTests.tsx
+++ b/packages/datetime/test/dateRangePickerTests.tsx
@@ -1141,6 +1141,14 @@ describe("<DateRangePicker>", () => {
             assert.isTrue(DateUtils.areSameDay(onChangeSpy.firstCall.args[0][0] as Date, defaultRange[0]));
         });
 
+        it("hovering over date does not change entered time", () => {
+            const harness = render({ timePrecision: "minute", defaultValue: defaultRange });
+            harness.changeTimeInput("minute", 10, "left");
+            const { left } = harness;
+            left.mouseEnterDay(5);
+            assert.equal((onChangeSpy.firstCall.args[0][0] as Date).getMinutes(), 10);
+        });
+
         it("changing time without date uses today", () => {
             render({ timePrecision: "minute" }).setTimeInput("minute", 45, "left");
             assert.isTrue(DateUtils.areSameDay(onChangeSpy.firstCall.args[0][0] as Date, new Date()));
@@ -1215,6 +1223,11 @@ describe("<DateRangePicker>", () => {
                     );
                 }
             },
+            changeTimeInput: (precision: TimePrecision | "hour", value: number, which: "left" | "right") =>
+                harness.wrapper
+                    .find(`.${DateClasses.TIMEPICKER}-${precision}`)
+                    .at(which === "left" ? 0 : 1)
+                    .simulate("change", { target: { value } }),
             clickNavButton: (which: "next" | "prev", navIndex = 0) => {
                 wrapper
                     .find(DatePickerNavbar)