From 5472c050d55f8ff4ed5e397d03cc83ce5e4cb28f Mon Sep 17 00:00:00 2001
From: Adi Dahiya <adahiya@palantir.com>
Date: Tue, 19 Jul 2022 15:39:27 -0400
Subject: [PATCH 1/3] Revert "[core] fix(Button, AnchorButton): preserve
 non-null disabled prop value (#5360)"

This reverts commit b6ea71e11b284d29ef6a05f01121d563f5903619.
---
 packages/core/src/components/button/abstractButton.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/core/src/components/button/abstractButton.tsx b/packages/core/src/components/button/abstractButton.tsx
index 2b9220d37f..331671b4be 100644
--- a/packages/core/src/components/button/abstractButton.tsx
+++ b/packages/core/src/components/button/abstractButton.tsx
@@ -120,8 +120,8 @@ export abstract class AbstractButton<E extends HTMLButtonElement | HTMLAnchorEle
     public abstract render(): JSX.Element;
 
     protected getCommonButtonProps() {
-        const { active, alignText, fill, large, loading = false, outlined, minimal, small, tabIndex } = this.props;
-        const disabled = this.props.disabled ?? loading;
+        const { active, alignText, fill, large, loading, outlined, minimal, small, tabIndex } = this.props;
+        const disabled = this.props.disabled || loading;
 
         const className = classNames(
             Classes.BUTTON,

From 40e48ea29c747e8ea8604b5d1e4047a913dbbcdb Mon Sep 17 00:00:00 2001
From: Adi Dahiya <adahiya@palantir.com>
Date: Tue, 19 Jul 2022 15:42:47 -0400
Subject: [PATCH 2/3] [core] docs: button loading prop overrides disabled

---
 .../src/components/button/abstractButton.tsx    | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/packages/core/src/components/button/abstractButton.tsx b/packages/core/src/components/button/abstractButton.tsx
index 331671b4be..a6e5948537 100644
--- a/packages/core/src/components/button/abstractButton.tsx
+++ b/packages/core/src/components/button/abstractButton.tsx
@@ -65,8 +65,9 @@ export interface IButtonProps<E extends HTMLButtonElement | HTMLAnchorElement =
     large?: boolean;
 
     /**
-     * If set to `true`, the button will display a centered loading spinner instead of its contents, and the button will be disabled.
-     * The width of the button is not affected by the value of this prop.
+     * If set to `true`, the button will display a centered loading spinner instead of its contents
+     * and the button will be disabled (_even if_ `disabled={false}`). The width of the button is
+     * not affected by the value of this prop.
      *
      * @default false
      */
@@ -120,7 +121,17 @@ export abstract class AbstractButton<E extends HTMLButtonElement | HTMLAnchorEle
     public abstract render(): JSX.Element;
 
     protected getCommonButtonProps() {
-        const { active, alignText, fill, large, loading, outlined, minimal, small, tabIndex } = this.props;
+        const {
+            active = false,
+            alignText,
+            fill,
+            large,
+            loading = false,
+            outlined,
+            minimal,
+            small,
+            tabIndex,
+        } = this.props;
         const disabled = this.props.disabled || loading;
 
         const className = classNames(

From 3e05f84914b32c32cefa66af2ee5b96b5af68146 Mon Sep 17 00:00:00 2001
From: Adi Dahiya <adahiya@palantir.com>
Date: Tue, 19 Jul 2022 16:26:16 -0400
Subject: [PATCH 3/3] add unit test to prevent future regressions

---
 packages/core/test/buttons/buttonTests.tsx | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/packages/core/test/buttons/buttonTests.tsx b/packages/core/test/buttons/buttonTests.tsx
index 4d2a808ac8..581e72099c 100644
--- a/packages/core/test/buttons/buttonTests.tsx
+++ b/packages/core/test/buttons/buttonTests.tsx
@@ -79,6 +79,14 @@ function buttonTestSuite(component: React.ComponentClass<any>, tagName: string)
             assert.isTrue(wrapper.hasClass(Classes.DISABLED));
         });
 
+        // This tests some subtle (potentialy unexpected) behavior, but it was an API decision we
+        // made a long time ago which we rely on and should not break.
+        // See https://github.com/palantir/blueprint/issues/3819#issuecomment-1189478596
+        it("button is disabled when the loading prop is true, even if disabled={false}", () => {
+            const wrapper = button({ disabled: false, loading: true });
+            assert.isTrue(wrapper.hasClass(Classes.DISABLED));
+        });
+
         it("clicking button triggers onClick prop", () => {
             const onClick = spy();
             button({ onClick }).simulate("click");