Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum visitor builders do not compile with UNKNOWN member #2110

Open
invliD opened this issue Sep 29, 2023 · 1 comment
Open

Enum visitor builders do not compile with UNKNOWN member #2110

invliD opened this issue Sep 29, 2023 · 1 comment

Comments

@invliD
Copy link
Member

invliD commented Sep 29, 2023

What happened?

When an enum has a member called UNKNOWN, the resulting code contains two interfaces called UnknownStageVisitorBuilder, which fails to compile. I believe this is the same as #2100, but for UNKNOWN instead of COMPLETED.

What did you want to happen?

No compile errors.
@mswintermeyer
Copy link
Contributor

Worth addressing why the programmatic API even allows UNKNOWN given we try to disallow it. Seems some validation got missed. https://github.com/palantir/conjure/blob/5cefea79ca7a5cf1c7565833f525afaff56ead93/conjure-core/src/main/java/com/palantir/conjure/defs/validator/EnumValueDefinitionValidator.java#L52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@invliD @mswintermeyer