Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common.IsActor() does not actually use ctx and can be simplified. #727

Open
atatkin opened this issue Mar 13, 2024 · 0 comments
Open

common.IsActor() does not actually use ctx and can be simplified. #727

atatkin opened this issue Mar 13, 2024 · 0 comments

Comments

@atatkin
Copy link
Contributor

atatkin commented Mar 13, 2024 

          Looking at `IsActor`, it looks like it doesn't actually use the first `ctx` argument. If you want to simplify this and avoid passing a `context.Context` around, I think we could remove that argument.

Originally posted by @bluekeyes in #725 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atatkin