Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths in public_url are removed from OAuth routes #804

Closed
bluekeyes opened this issue Jul 29, 2024 · 0 comments · Fixed by #806
Closed

Paths in public_url are removed from OAuth routes #804

bluekeyes opened this issue Jul 29, 2024 · 0 comments · Fixed by #806
Labels
bug Something isn't working

Comments

@bluekeyes
Copy link
Member

#730 changed to use the public_url field to configure OAuth, since proxies may not always forward the Host header. Unfortunately, this drops any path component from public_url because the default auth path is absolute. We should join the paths instead.
@bluekeyes bluekeyes added the bug Something isn't working label Jul 29, 2024
This was referenced Jul 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include base path in OAuth2 redirect URL palantir/policy-bot
1 participant
@bluekeyes