jsx-no-lambda: allow lambdas on ref attribute (#107)

palantir · Jul 18, 2017 · 21f3308 · 21f3308
1 parent 157a4fa
commit 21f3308
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/rules/jsxNoLambdaRule.ts b/src/rules/jsxNoLambdaRule.ts
@@ -54,6 +54,12 @@ function walk(ctx: Lint.WalkContext<void>) {
                 return;
             }
 
+            // Ignore "ref" attribute.
+            // ref is not part of the props so using lambdas here will not trigger useless re-renders
+            if (node.name.text === "ref") {
+                return;
+            }
+
             const { expression } = initializer;
             if (expression !== undefined && isLambda(expression)) {
                 return ctx.addFailureAtNode(expression, Rule.FAILURE_STRING);

diff --git a/test/rules/jsx-no-lambda/test.tsx.lint b/test/rules/jsx-no-lambda/test.tsx.lint
@@ -35,8 +35,8 @@ const anotherOkFunction = () {
 class TypicalRefHandler extends React.Component<{}, {}> {
     private element: HTMLElement;
     public render() {
+        // ref is not part of the props so using lambdas here will not trigger useless re-renders
         return <div ref={(ref) => this.element = ref} />
-                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~     [0]
     }
 }