Implement jsx-equals-spacing rule #104
Conversation
|
I strongly recommend adding a fixer here, it should be pretty simple. You just have to add a text replacement for " " -> "". Can you look into getting CI status reported here? |
|
hey @adidahiya, I'm running into some weird issues with the fixer. Here is what the test output looks like without the fixer applied: It looks like what you would expect to see. Here is what the test output looks like with the fixer applied: To me it looks like the test should pass yet it fails. Any pointers here? As per the CircleCI status, I did build my fork through the CircleCI's online interface. It only showed me the master branch, however. Not sure where I'm going wrong here. |
|
@bolatovumar can you push your in-progress fixer code here so I can take a look? |
|
@adidahiya, sorry, it took me a while. Add my failing WIP fixers above. The commands I'm running to test the fixers are (from the root of the repo after running In both cases it looks like the console output I'm getting looks something like this:
Hope this is enough detail. |
|
@bolatovumar I've seen something similar when forgot to add empty line at the end of a UPD. Checked changes from PC and now I see that this should be the case: IIRC all lines that mark errors and starts with ~ or [0] etc. should be skipped. All other empty lines should be exactly same as in |
| <App {...props} /> | ||
|
|
||
| <App foo = {bar} /> | ||
|
|
| <App foo = {bar} /> | ||
|
|
||
| <App foo = {bar} /> | ||
|
|
|
|
||
| <App foo = {bar} /> | ||
|
|
||
| <App foo = {bar} bar = {baz} />; |
There was a problem hiding this comment.
Probably missing empty line after this one.
| <App foo={e => bar(e)} /> | ||
| <App foo={bar} /> | ||
| <App foo={bar} /> | ||
| <App foo={bar} bar={baz} /> |
There was a problem hiding this comment.
Probably missing empty line after this one.
| <App /> | ||
| <App foo /> | ||
| <App foo="bar" /> | ||
| <App {...props} /> |
There was a problem hiding this comment.
Missing empty line after this one.
| <App {...props} /> | ||
| <App foo={e => bar(e)} /> | ||
| <App foo={bar} /> | ||
| <App foo={bar} /> |
There was a problem hiding this comment.
Missing empty line after this one.
|
@IllusionMH, alright, adding and removing line breaks seems to help |
Issue #103
Ported over the rule from eslint-plugin-react.
Included the exact same tests as in that plugin.
No automatic fixer because I don;t know how it works and never use it myself.
I reckon it would be really easy to add the fixer if someone wanted to do.