Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check key in JSX spread attribute (jsx-key) #129

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Check key in JSX spread attribute (jsx-key) #129

merged 1 commit into from
Dec 14, 2017

Conversation

jomasti
Copy link
Contributor

@jomasti jomasti commented Dec 9, 2017

This looks for key in an object literal being spread into the component.

Closes #122

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint-react, @jomasti! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. can you please enable CI by going to https://circleci.com/add-projects?

@jomasti
Copy link
Contributor Author

jomasti commented Dec 14, 2017

I finally figured out how to get a build running for my branch. Shouldn't this project be set up to build PRs from forks, though? Anyway, the build fails due to Yarn not being able to find the binary for npm-run-all. It looks to be the same issue affecting the builds on master. From my quick research, it looks like the newer version of Yarn being used isn't compatible with the version of Node used by the container in CircleCI.

@adidahiya
Copy link
Contributor

Good catch, I've fixed that on master here by migrating to CircleCI 2.0 #131

As a bonus, we also get testing of typescript@next. Can you pull in master to get the latest CI checks here?

This looks for `key` in an object literal being spread into the component.
@jomasti
Copy link
Contributor Author

jomasti commented Dec 14, 2017

Awesome! Build is good now.

@adidahiya adidahiya merged commit a4a5906 into palantir:master Dec 14, 2017
@jomasti jomasti deleted the issue-122 branch December 14, 2017 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants