Support JSX Fragment syntax for jsx-wrap-multiline. #130
Conversation
|
Thanks for your interest in palantir/tslint-react, @dmiller9911! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
| elementClose: ts.LineAndCharacter, | ||
| closingTag?: ts.JsxClosingElement, | ||
| ) { | ||
| attributes = Array.isArray(attributes) ? attributes : attributes.properties; | ||
| if (attributes.length === 0) { | ||
| const attrs = Array.isArray(attributes) ? attributes : attributes.properties; |
There was a problem hiding this comment.
TS 2.6.2 did not like the reassignment of attributes. Setting to a new variable and adding the typing resolved the type checks.
Yes please, feel free to upgrade |
| @@ -34,6 +34,6 @@ | |||
| "path": "^0.12.7", | |||
| "tslint": "^5.5.0", | |||
| "tslint-language-service": "^0.9.6", | |||
| "typescript": "~2.4.2" | |||
| "typescript": "~2.6.2" | |||
|
Will wait for ajafff/tsutils#17 before updating tsutils. |
dmiller9911
force-pushed
the
jsx-wrap-multiline-fragments
branch
from
85c6931 to
f3d49ee
Compare
|
@dmiller9911 can you please pull in master to get the new CI setup and required checks? Also enable CI on your branch if you haven't yet. |
Add tests to verify positive and negative cases. Upgrade ts devDependency to 2.6.2.
dmiller9911
force-pushed
the
jsx-wrap-multiline-fragments
branch
from
f3d49ee to
20ed872
Compare
Fixes #124
Added a check for ts.syntaxKind.JsxFragment in jsx-wrap-multiline. A newer version of
tsutilshas this check as well, but I was unsure of the policy for updating dependencies. If you would rather upgrade I will do that instead.Add tests to verify positive and negative cases. Upgrade ts devDependency to 2.6.2.