[completed-docs] exported variable parsed as internal variable

[bumbleblym]

Bug Report

• TSLint version: 4.5.1
• TypeScript version: 2.2.1
• Running TSLint via: (pick one) CLI / Node.js API / VSCode / grunt-tslint / Atom / Visual Studio / etc

TypeScript code being linted

export const Null = null

with tslint.json configuration:

{
  "rules": {
    "completed-docs": [true, {
      "variables": {
        "visibilities": [
          "exported"
        ]
      }
    }]
  }
}

Actual behavior

"all": lint error
"exported": no lint error
"internal": lint error

Expected behavior

"all": lint error
"exported": lint error
"internal": no lint error

exported variable is being parsed as internal. repro

Also, documented visibilities type is inconsistent:
schema: enum
example: array enum
implementation: array enum

perhaps #629 should consider docs as well.

[JoshuaKGoldberg]

I'll take a look after #2415 goes in.

[reduckted]

This bug is caused by the fact that the VariableDeclaration does not have modifiers. The modifiers are on the VariableStatement which is a grandparent of a VariableDeclaration.

VariableStatement               <-- The relevant modifiers are here.
 └─ VariableDeclarationList
     └─ VariableDeclaration     <-- This node is checked.

I've made a fix for this, but it requires some changes that I've made in PR #2911 to allow the modifiers from a different node to be used. Once that PR is merged, I'll submit another PR for this bug.

[JoshuaKGoldberg]

Bump @reduckted - still interested in a followup PR?

[reduckted]

Doh! Totally forgot about this. Yes, I'll take a look into it again. :)

[reduckted]

Hmm, looks like I already fixed this in #2950. ¯\_(ツ)_/¯

Edit: Which, for the record, was released in v5.6.0

[ajafff]

Looking at the tests added in that PR I can confirm that this is fixed.