Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add code coverage #439

Closed
adidahiya opened this issue Jun 19, 2015 · 5 comments
Closed

Add code coverage #439

adidahiya opened this issue Jun 19, 2015 · 5 comments
Labels
Domain: Unit Testing Resolution: Fixed Type: Enhancement
Milestone
TSLint v4.x

Comments

@adidahiya
Copy link
Contributor

We could even get a fancy coverage % badge via https://coveralls.io/
@ashwinr
Copy link
Contributor

ashwinr commented Jun 21, 2015

+1 for coveralls + istanbul

@leeavital leeavital self-assigned this Jun 22, 2015
@leeavital
Copy link
Contributor

It looks like istanbul works by hooking into require() statements to differentiate between external libraries and testable code. I'm going to wait on doing this until #465 (ES6 modules) is done.

@adidahiya
Copy link
Contributor Author

hmm that shouldn't be the case; we were able to set up Istanbul on front end projects that don't use require() imports. But I'm also totally cool with doing the module conversion first.

@adidahiya adidahiya assigned jkillian and unassigned leeavital Jan 21, 2016
@adidahiya adidahiya added this to the TSLint 4.x milestone Jan 21, 2016
@adidahiya
Copy link
Contributor Author

https://coveralls.io/github/palantir/tslint

@adidahiya
Copy link
Contributor Author

we're pretty good on this front now.

@ajafff ajafff mentioned this issue Mar 31, 2017
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Domain: Unit Testing Resolution: Fixed Type: Enhancement
Projects
None yet
Milestone
TSLint v4.x
Development

No branches or pull requests
4 participants
@ashwinr @adidahiya @jkillian @leeavital