Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

rule suggestion: no-internal-module #513

Closed
vvakame opened this issue Jul 20, 2015 · 5 comments
Closed

rule suggestion: no-internal-module #513

vvakame opened this issue Jul 20, 2015 · 5 comments

Comments

@vvakame
Copy link
Contributor

vvakame commented Jul 20, 2015

microsoft/TypeScript#2159
TypeScript 1.5.3 released. it has namespace keyword.
internal module is confusion name. I think use namespace instead of internal module.

if I create the pull request, will you accept it?

@ashwinr
Copy link
Contributor

ashwinr commented Jul 20, 2015

yes please. let's call the rule name no-module-keyword.

@vvakame
Copy link
Contributor Author

vvakame commented Jul 20, 2015

@ashwinr yeah! I have one question. external module syntax are required in es6 module context.
like this.

declare module "foobar" {
    export default function (): string;
}

can I use no-module-keyword ?

@ashwinr
Copy link
Contributor

ashwinr commented Jul 20, 2015

But that's a module declaration and not a module definition. We should only be forbidding module definitions using the module keyword. Maybe the rule name should be no-module-definition

@adidahiya
Copy link
Contributor

how about no-internal-module? I think "module definition" may be confusing / require lookup in our documentation

EDIT: just realized that the issue title had the same name suggestion. so looks like we arrived at the same thing independently :)

@ashwinr
Copy link
Contributor

ashwinr commented Jul 20, 2015

sgtm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants