Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xy_writer() allocates more than it should #131

Closed
paleolimbot opened this issue Jan 5, 2022 · 1 comment · Fixed by #154
Closed

xy_writer() allocates more than it should #131

paleolimbot opened this issue Jan 5, 2022 · 1 comment · Fixed by #154

Comments

@paleolimbot
Copy link
Owner

Anecdotally much more, but at the very least it could avoid allocating the zm vectors until they are needed.
@paleolimbot
Copy link
Owner Author

This is one where we should use growables implemented for nanoarrow + the altrep implemented on top of that to replace most of this!

@paleolimbot paleolimbot mentioned this issue Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't allocate z or m members of an xy unless they're needed paleolimbot/wk
1 participant
@paleolimbot