Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move namespace logic from app01/02 to common components/ folder #29

Open
palladius opened this issue Aug 24, 2022 · 0 comments
Open

Move namespace logic from app01/02 to common components/ folder #29

palladius opened this issue Aug 24, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@palladius
Copy link
Owner

Is there a reason why the namespace part was put in the apps: https://github.com/palladius/clouddeploy-platinum-path/blob/main/apps/app01/k8s/overlays/dev/namespace.yaml
and not consolidated in the base components/ part (https://github.com/palladius/clouddeploy-platinum-path/tree/main/components/common/dev)?

I don't see a reason to do this within apps instead of on component-level. And I would strongly recommend lifting this into component like you are proposing. 👍

@palladius palladius self-assigned this Aug 24, 2022
@palladius palladius added the enhancement New feature or request label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant