Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB backend implementation. #213

Closed
necat1 opened this issue Feb 25, 2024 · 4 comments
Closed

DynamoDB backend implementation. #213

necat1 opened this issue Feb 25, 2024 · 4 comments

Comments

@necat1
Copy link

necat1 commented Feb 25, 2024

Hey, i have implemented DynamoDBSessionInterface, and it works locally. How can i create PR? I don't have access to repo.

@Lxstr
Copy link
Contributor

Lxstr commented Feb 25, 2024

Hi there, you need to create a fork of flask session, push your feature branch (call it dynamodb) to your forked repo then create a pull request (preferably to development branch). Note that there have been quite a few changed on development branch that haven't been merged yet so you may need to rewrite slightly

@Lxstr
Copy link
Contributor

Lxstr commented Feb 27, 2024

Waiting for your PR. Closing this issue

@Lxstr Lxstr closed this as completed Feb 27, 2024
@necat1
Copy link
Author

necat1 commented Feb 27, 2024

Thanks, here is the adapted PR for development branch #214
I can also create PR for current main branch, code is ready either way and is smaller than the one in development branch. That is if next release is going to take long time.

@Lxstr
Copy link
Contributor

Lxstr commented Feb 27, 2024

Looks pretty good. Thanks for also adding the tests. I'll review in detail in the next few days. Next release also in the next few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants