Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

see if we can remove the rtd docsearch_disabled flag #40

Closed
davidism opened this issue May 13, 2021 · 0 comments · Fixed by #44
Closed

see if we can remove the rtd docsearch_disabled flag #40

davidism opened this issue May 13, 2021 · 0 comments · Fixed by #44

Comments

@davidism
Copy link
Member

When RTD was working on their new search feature, we disabled it because the results it returned weren't as useful as Sphinx's search yet.

{%- if READTHEDOCS and not readthedocs_docsearch %}
<script>
if (typeof READTHEDOCS_DATA !== 'undefined') {
if (!READTHEDOCS_DATA.features) {
READTHEDOCS_DATA.features = {};
}
READTHEDOCS_DATA.features.docsearch_disabled = true;
}
</script>
{%- endif %}

I think we can disable this now, we can play around with the setting in one of the projects and compare the results to see if RTD search is okay to use now.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant