Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inline type annotations for datastructures #2970

Closed
davidism opened this issue Oct 27, 2024 · 2 comments · Fixed by #2974
Closed

inline type annotations for datastructures #2970

davidism opened this issue Oct 27, 2024 · 2 comments · Fixed by #2974
Assignees
@davidism
Milestone
3.1.0

Comments

@davidism
Copy link
Member

Currently we have a bunch of .pyi files with the annotations, because Python <= 3.8 didn't support generic list and dict subclassing. Now that we support >= 3.9, we should be able to move all the annotations into the Python code and remove the stubs.
@davidism davidism added this to the 3.1.0 milestone Oct 27, 2024
@sgaynetdinov
Copy link

@davidism Hi, is this task available?

@davidism davidism self-assigned this Oct 29, 2024
@davidism
Copy link
Member Author

I'm currently most of the way through it, thanks for offering though!

This was referenced Oct 29, 2024
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidism davidism

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

inline annotations for datastructures pallets/werkzeug
2 participants
@davidism @sgaynetdinov