chore: Add PancakeSwap Top 100 List #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chef-Cheems
reviewed
Jun 2, 2021
Chef-Cheems
reviewed
Jun 2, 2021
Chef-Cheems
reviewed
Jun 2, 2021
| keywords: ["pancakeswap", "extended"], | ||
| logoURI: | ||
| "https://assets.trustwalletapp.com/blockchains/smartchain/assets/0x0E09FaBB73Bd3Ade0a17ECC321fD13a19e81cE82/logo.png", | ||
| sort: true, | ||
| }, | ||
| "pancakeswap-top-100": { |
There was a problem hiding this comment.
This is good, you'r getting there 👍
Need to do similar modification in checksum.ts (just import list and add to the lists) and default.test.ts (add pancakeswap-top-100 in here.
- also make new command in package.json for top100 similar to other ones, read more in readme
https://github.com/pancakeswap/pancake-toolkit/tree/master/packages/token-lists#how-to-add-new-lists-within-this-repository
Chef-Cheems
approved these changes
Jun 2, 2021
Chef-Cheems
reviewed
Jun 2, 2021
| }, | ||
| { | ||
| "name": "Wault", | ||
| "symbol": "WAULTx", | ||
| "address": "0xB64E638E60D154B43f660a6BF8fD8a3b249a6a21", | ||
| "address": "0xB64E638E60D154B43f660a6BF8fD8a3b249a6a2", |
There was a problem hiding this comment.
Hm.... 1 in the end got lost somehow, probably I haven't selected it when I copied the list to you
Chef-Cheems
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.