Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Kit] style(uikit): Slider disabled state #24

Merged
merged 1 commit into from
Mar 22, 2021
Merged

[UI Kit] style(uikit): Slider disabled state #24

merged 1 commit into from
Mar 22, 2021

Conversation

hachiojidev
Copy link
Contributor

image

@hachiojidev hachiojidev requested a review from RabbitDoge as a code owner March 22, 2021 01:55
RabbitDoge
RabbitDoge reviewed Mar 22, 2021
View reviewed changes
packages/pancake-uikit/src/components/Slider/styles.ts
};

const getBaseThumbStyles = ({ isMax, disabled }: StyledInputProps) => `
-webkit-appearance: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appearance: none; should be enough here

@hachiojidev hachiojidev merged commit da2ae4a into master Mar 22, 2021
@hachiojidev hachiojidev deleted the uikit/slider-disabled-state branch March 22, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RabbitDoge RabbitDoge RabbitDoge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hachiojidev @RabbitDoge