fix: Slider step label position #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachiojidev
suggested changes
Mar 30, 2021
| @@ -6,7 +6,7 @@ import bunnyHeadMax from "./svg/bunnyhead-max.svg"; | |||
| import bunnyButt from "./svg/bunnybutt.svg"; | |||
|
|
|||
| interface SliderLabelProps { | |||
| progress: number; | |||
| progress: string; | |||
There was a problem hiding this comment.
it can be "px" or % values. so better to use string type I think.
Comment on lines
-6
to
-9
| // We need to adjust the offset as the percentage increases, as 100% really is 100% - label width. | ||
| // The number 10 is arbitrary, but seems to work... | ||
| const LABEL_OFFSET = 10; | ||
|
|
There was a problem hiding this comment.
Can you explain why this was necessary to remove?
There was a problem hiding this comment.
This is not used in the current change.
hachiojidev
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.