fix: React dom failure when passing unknown props to child component #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
memoyil
commented
Apr 2, 2021
memoyil
commented
RabbitDoge
reviewed
Apr 5, 2021
| } | ||
|
|
||
| const InactiveButton: PolymorphicComponent<InactiveButtonProps, "button"> = styled(Button)<InactiveButtonProps>` | ||
| background-color: transparent; | ||
| color: ${({ theme, colorKey }) => theme.colors[colorKey]}; |
There was a problem hiding this comment.
The initial solution here is wrong imo. If you want to clean this, a better solution is to remove the colorkey attribute and compute the color based on the variant attribute
There was a problem hiding this comment.
@RabbitDoge is right in it is not an ideal solution. Do you mind fixing it? No worries if you can't, I will get to it.
There was a problem hiding this comment.
@hachiojidev I will try to fix it :) if I could not I will ask your help. Thanks 👍
There was a problem hiding this comment.
@hachiojidev can you review it again?
…nto fix/react_dom_failure_child_component_props
hachiojidev
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.