Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🔥 UI updates: button click animation, menu closing fix, men… #63

Merged
merged 3 commits into from
Apr 13, 2021

Conversation

canllama
Copy link
Contributor

@canllama canllama commented Apr 9, 2021

  • button press animation.
  • Fixed text getting cutoff or stacked during side panel closing.
  • Added missing transition to body for menu opening

…mation

- button press animation.
- Fixed text getting cutoff or stacked during side panel closing.
- Added missing transition to body for menu opening
@memoyil
Copy link
Contributor

memoyil commented Apr 10, 2021

Can you share the differences visually?

@canllama
Copy link
Contributor Author

the button changes are straight forward, adding a lil animation (can see in the storybook)

the panel fixes you can see the differences below during the pushing animation . You can see the differences below

pancake diff

Also previous the panel sliding out had an animation, but the body of the page didn't. now they are both synchronised with the same time and transition function

Eyes will blink when the logo is being hovered
@canllama canllama requested a review from Chef-Chungus as a code owner April 10, 2021 22:36
@canllama
Copy link
Contributor Author

Added a cute blink animation when hovering over the logo in the header
logo-blink

Copy link
Contributor

@hachiojidev hachiojidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this. I did build it locally and do not see the bunny blinking when I hover the logo. Am I missing something?

I do like the button press animation. I am going to send a preview to the designer and see what he thinks before merging this.

@canllama
Copy link
Contributor Author

Added the missing className for the Desktop logo :)

@canllama canllama requested a review from hachiojidev April 12, 2021 20:25
@hachiojidev hachiojidev merged commit 3d9ba48 into pancakeswap:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants