Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(card-ribbon): Add z-index value to ribbon and spread props to improve flexibility of component #88

Merged
merged 1 commit into from
Apr 29, 2021
Merged

fix(card-ribbon): Add z-index value to ribbon and spread props to improve flexibility of component #88

merged 1 commit into from
Apr 29, 2021

Conversation

ChefHutch
Copy link
Contributor

  • Using this component in the new pool cards
  • Lack of z-index means with other card header elements it disappears behind them
  • Added ...props spreading to improve utility of component

Sad
Screenshot 2021-04-28 at 18 18 22

Happy
Screenshot 2021-04-28 at 18 17 53

@ChefHutch ChefHutch self-assigned this Apr 28, 2021
@ChefHutch ChefHutch mentioned this pull request Apr 28, 2021
Merged
@RabbitDoge RabbitDoge merged commit 2fb19f1 into pancakeswap:master Apr 29, 2021
@ChefHutch ChefHutch deleted the fix/add-z-index-to-ribbon branch April 29, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chef-Cheems Chef-Cheems Chef-Cheems approved these changes

@RabbitDoge RabbitDoge RabbitDoge approved these changes

@Chef-Chungus Chef-Chungus Awaiting requested review from Chef-Chungus

@hachiojidev hachiojidev Awaiting requested review from hachiojidev

Assignees

@ChefHutch ChefHutch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChefHutch @RabbitDoge @Chef-Cheems