feat: incldue bin liquidity in getBin for BinPool #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
commented
Jun 28, 2024
| { | ||
| (binReserveX, binReserveY) = pools[id].getBin(binId); | ||
| PoolKey memory key = poolIdToPoolKey[id]; |
There was a problem hiding this comment.
this also imply we might need poolIdToPoolKey to stay since the param is poolId which does not include binStep
chefburger
approved these changes
Jun 28, 2024
|
verified quite hard to replicate the entire math on subgraph, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve https://github.com/pancakeswap/pancake-v4-core/issues/100
This PR includes a third return value
binLiquidityinpoolManager.getBin(poolId, binId)