-
Notifications
You must be signed in to change notification settings - Fork 5
Extend "adjust settings" function #75
Comments
„Voltage“ : .., what should these parameters manage? |
Current and MaxCurrent Setting will be added on future boards. This can be just added to the SPI Protocol without function. |
These are changes, which are relevant for production firmware, not only the calibration firmware |
Code checked, looks okay for me |
What I found is an nlohmann/json#677:
nlohman:
It is a recomendation from nlohman. It seems that some JSON engine fixes are required... |
NLOHMAN JSON has been patched with std::sprintf. |
review done, works great :) |
„Gain“ : ..,
„DAC1.raw“ : ..,
„DAC2.raw“ : ..,
„DAC3.raw“ : ..,
„DAC4.raw“ : ..,
„Voltage“ : ..,
„Current“ : ..,
„MaxCurrent“ : ..,
„DACsw“ : ..
}
Definition of Done
code for mentioned task is complete. examples & documentations are complete.
build chains are tested
corresponding branch is closed
merging is done
The text was updated successfully, but these errors were encountered: