Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix signature of frame.filter #964

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix signature of frame.filter #964

merged 1 commit into from
Aug 2, 2024

Conversation

refack
Copy link
Contributor

@refack refack commented Jul 28, 2024

items can be ListLike

It is turned into and Index which can handle and ListLike as data
https://github.com/pandas-dev/pandas/blob/9b375be5aa3610e8a21ef0b5b81e4db04270f3d3/pandas/core/generic.py#L5448

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that fails without your PR and works with your PR?

@refack
Copy link
Contributor Author

refack commented Jul 30, 2024

Can you add a test

Allready started (great minds and such)

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jul 31, 2024

CI is failing because pyright got upgraded and we have to remove some #pyright ignore statements. This is in PR #967 . Once that is merged in, then you can merge in the new main in your branch and push, and I will test the CI again.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jul 31, 2024

CI is failing because pyright got upgraded and we have to remove some #pyright ignore statements. This is in PR #967 . Once that is merged in, then you can merge in the new main in your branch and push, and I will test the CI again.

This is now merged, so go ahead and merge with main and push

pandas-stubs/core/frame.pyi Outdated Show resolved Hide resolved
items can be ListLike
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @refack

@Dr-Irv Dr-Irv merged commit c88d050 into pandas-dev:main Aug 2, 2024
13 checks passed
@refack refack deleted the patch-1 branch August 2, 2024 20:35
@refack
Copy link
Contributor Author

refack commented Aug 2, 2024

Thanks @refack

Keep up the great work

@refack
Copy link
Contributor Author

refack commented Aug 21, 2024

@Dr-Irv apropos, I just stumbled on pandas-dev/pandas#47215
LOL
It's nice to see things stay consistent even after 2 years 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants