Skip to content

Commit

Permalink
DOC: Update documentation for TestCase usage
Browse files Browse the repository at this point in the history
tm.TestCase no longer follows the nosetest idiom,
so it is here to stay, so update the documentation
to say that we are using it still.

Closes gh-15990.
  • Loading branch information
gfyoung committed May 3, 2017
1 parent b11bd87 commit 51eab8c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
7 changes: 1 addition & 6 deletions doc/source/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -633,12 +633,7 @@ framework that will facilitate testing and developing. Thus, instead of writing
....
Sometimes, it does make sense to bundle test functions together into a single class, either because the test file is testing multiple functions from a single module, and
using test classes allows for better organization. However, instead of inheriting from ``tm.TestCase``, we should just inherit from ``object``:

.. code-block:: python
class TestReallyCoolFeature(object):
....
using test classes allows for better organization. If test classes are used, make sure that they do inherit from ``tm.TestCase``.

Using ``pytest``
~~~~~~~~~~~~~~~~
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/test_algos.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ def test_complex_sorting(self):
# gh 12666 - check no segfault
# Test not valid numpy versions older than 1.11
if pd._np_version_under1p11:
self.skipTest("Test valid only for numpy 1.11+")
pytest.skip("Test valid only for numpy 1.11+")

x17 = np.array([complex(i) for i in range(17)], dtype=object)

Expand Down

0 comments on commit 51eab8c

Please sign in to comment.