-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Support merging DataFrames on a combination of columns and index levels #14355
Comments
+1 on this proposal. As I said in the related issue (#14353 (comment)), would be nice to have a general solution for this, but for now enabling this behaviour for specific functions/keywords is fine for me. @jreback @wesm @TomAugspurger @shoyer @sinhrks @chris-b1 any concerns of feedback regarding this proposal, before work is done to implement it? (@jmmease you plan to tackle this if OK?) |
@jorisvandenbossche Yes, if the direction is agreeable I plan to begin tackling this set of issues during the next month or two. |
I think I'm in favor of all the changes. Thanks for taking them on @jmmease! |
Yes, seems like a good idea to me. |
We do need to clarify how we will handle conflicting index/column names in a uniform way. For backwards compatibility, I think we need to always check column names before falling back to use index names. |
@shoyer Agreed regarding conflict resolution. Thanks for the feedback! |
.groupby
ENH/API: clarify groupby by to handle columns/index names #5677.sort_values
ENH: Support sorting DataFrames by a combination of columns and index levels #14353, though this is directly in combat with.sort_index
and non-explict.merge
(this issue)Overview
@jorisvandenbossche
As a part of the Pandas 1.0 goal to "Make the index/column distinction less painful (#5677, #8162)" I propose that the
df.merge
method support merging DataFrames on a combination of columns and index levels.This could be accomplished in the API by allowing the
on
,left_on
, andright_on
keywords to accept a combination of column names and index level names. Any index levels that are joined on would be preserved as index levels in the resulting merged DataFrame, while all other index levels would be removed.This proposal is in the spirit of #5677 for
df.groupby
and #14353 fordf.sort_values
.The text was updated successfully, but these errors were encountered: