Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add warning to append about inefficiency #16418

Closed
jorisvandenbossche opened this issue May 22, 2017 · 3 comments · Fixed by #17017
Closed

DOC: add warning to append about inefficiency #16418

jorisvandenbossche opened this issue May 22, 2017 · 3 comments · Fixed by #17017
Labels
Milestone

Comments

@jorisvandenbossche
Copy link
Member

In many cases, using append to add rows is not the best way to go, as this is very inefficient (certainly if you do this in a for loop, each time taking a copy)

If in a situation where you have this pattern of appending in a for loop, you typically want to append to a list and then concatenate all at once using concat.

Would by good to add a note about this in the append docstring.

@mogillies
Copy link

I'm working on it.

@shanral
Copy link
Contributor

shanral commented Jul 15, 2017

I've picked this up since it seems available again.

@mogillies
Copy link

mogillies commented Jul 16, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants