Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF/INT: refactor concatenation of values in Block.concat_same_type #17997

Closed
jorisvandenbossche opened this issue Oct 27, 2017 · 2 comments
Closed

REF/INT: refactor concatenation of values in Block.concat_same_type #17997

jorisvandenbossche opened this issue Oct 27, 2017 · 2 comments
Assignees
@jorisvandenbossche
Labels
Clean Internals Related to non-user accessible pandas implementation

Comments

@jorisvandenbossche
Copy link
Member

See comment #17954 (comment) and #17728 (comment) about suggestions to make the implementation of concat_same_type cleaner.
@jorisvandenbossche jorisvandenbossche added Clean Internals Related to non-user accessible pandas implementation labels Oct 27, 2017
@jorisvandenbossche jorisvandenbossche added this to the 0.22.0 milestone Oct 27, 2017
@jorisvandenbossche jorisvandenbossche self-assigned this Oct 27, 2017
@jorisvandenbossche jorisvandenbossche mentioned this issue Oct 27, 2017
Merged
@jreback jreback modified the milestones: 0.23.0, Next Major Release Apr 14, 2018
@jbrockmendel
Copy link
Member

Block.concat_same_type is gone, is this closeable/updateable?

@jbrockmendel jbrockmendel added the Closing Candidate May be closeable, needs more eyeballs label Sep 22, 2020
@jorisvandenbossche
Copy link
Member Author

Yes, this can indeed be closed I think. The referenced comments are now also outdated with the introduction of the get_common_dtype interface used in the concat code.

@jorisvandenbossche jorisvandenbossche removed the Closing Candidate May be closeable, needs more eyeballs label Sep 22, 2020
@jorisvandenbossche jorisvandenbossche modified the milestones: Contributions Welcome, No action Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorisvandenbossche jorisvandenbossche

Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jreback @jorisvandenbossche @jbrockmendel