Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Re)-deprecate order keyword in factorize #19727

Closed
TomAugspurger opened this issue Feb 16, 2018 · 3 comments · Fixed by #19751
Closed

(Re)-deprecate order keyword in factorize #19727

TomAugspurger opened this issue Feb 16, 2018 · 3 comments · Fixed by #19751
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Deprecate Functionality to remove in pandas good first issue
Milestone
0.23.0

Comments

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Feb 16, 2018 •
edited
Loading

In #6930 we deprecated order.

As of 0.18.1, the keyword was no-longer documented, and doesn't raise, but wasn't actually removed.

In [3]: pandas.factorize([0, 1], order=True)
Out[3]: (array([0, 1]), array([0, 1]))

In [4]: pandas.__version__
Out[4]: '0.18.1'
@TomAugspurger TomAugspurger changed the title (Re)-deprecate order keyword in (Re)-deprecate order keyword in factorize Feb 16, 2018
@TomAugspurger TomAugspurger added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Deprecate Functionality to remove in pandas labels Feb 16, 2018
@TomAugspurger TomAugspurger added this to the Next Major Release milestone Feb 16, 2018
@TomAugspurger
Copy link
Contributor Author

I don't have a strong preference on deprecating vs. just removing. Probably best to deprecate for one release.

@jorisvandenbossche
Copy link
Member

To be clear, it seems the order keyword does nothing (so it was forgotten to be removed from the signature).

@EricChea
Copy link
Contributor

I can take this. I'm made some mods to deprecate_kwargs in pandas/util/_decorators.py to accommodate and just need to write some tests.

@EricChea EricChea mentioned this issue Feb 18, 2018
Merged
4 tasks
@jreback jreback modified the milestones: Next Major Release, 0.23.0 Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Deprecate Functionality to remove in pandas good first issue
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

DEPR: Add deprecation warning for factorize() order keyword
4 participants
@jreback @jorisvandenbossche @TomAugspurger @EricChea